Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][MIG]partner_contact_department #908

Merged
merged 21 commits into from
Jul 17, 2020
Merged

[13.0][MIG]partner_contact_department #908

merged 21 commits into from
Jul 17, 2020

Conversation

HaraldPanten
Copy link
Contributor

MIG to V13

yajo and others added 19 commits May 7, 2020 19:37
@yajo @HaraldPanten
Rename to partner_contact_department.
6074665
@feketemihai @HaraldPanten
Add ondelete option to parent_id, runbot fails to lack of attribute.
fe0fb51
@cubells @HaraldPanten
partner_contact_department
eabbd43 
    * Add tests
    * Other minor changes
@oca-transbot @HaraldPanten
OCA Transbot updated translations from Transifex
9de108d
@chienandalu @HaraldPanten
partner_contact_department: Migration to 10.0
621b57e
@pedrobaeza @HaraldPanten
partner_department: Depend on sales_team
6a0b373 
As it uses some XML-IDs from it.
@oca-transbot @HaraldPanten
OCA Transbot updated translations from Transifex
cf00187
@oca-travis @HaraldPanten
Update partner_contact_department.pot
e841987
@HaraldPanten
Translated using Weblate (Português (Brasil))
d004978 
Currently translated at 100,0% (16 of 16 strings)

Translation: partner-contact-10.0/partner-contact-10.0-partner_contact_department
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-10-0/partner-contact-10-0-partner_contact_department/pt_BR/
@MiquelRForgeFlow @HaraldPanten
partner_contact_department: Migration to 11.0
d46a824
@Nikul-Chaudhary @HaraldPanten
[MIG] partner_contact_department v11 to v12
4abff35
@OCA-git-bot @HaraldPanten
[UPD] README.rst
337d496
@oca-travis @HaraldPanten
[UPD] Update partner_contact_department.pot
7a95225
@oca-transbot @HaraldPanten
Update translation files
bb6400b 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: partner-contact-12.0/partner-contact-12.0-partner_contact_department
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_contact_department/
@OCA-git-bot @HaraldPanten
[UPD] README.rst
f852b64
@HaraldPanten
Translated using Weblate (Portuguese (Brazil))
5875b38 
Currently translated at 100.0% (15 of 15 strings)

Translation: partner-contact-12.0/partner-contact-12.0-partner_contact_department
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_contact_department/pt_BR/
@Galoperd @HaraldPanten
Translated using Weblate (Spanish)
d955acc 
Currently translated at 100.0% (15 of 15 strings)

Translation: partner-contact-12.0/partner-contact-12.0-partner_contact_department
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_contact_department/es/
@pedrocs-exo @HaraldPanten
Translated using Weblate (Portuguese)
019494d 
Currently translated at 100.0% (15 of 15 strings)

Translation: partner-contact-12.0/partner-contact-12.0-partner_contact_department
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_contact_department/pt/
@HaraldPanten
[IMP] partner_contact_department: black, isort, prettier
13851f1
@rousseldenis rousseldenis added this to the 13.0 milestone May 8, 2020
@OCA-git-bot OCA-git-bot mentioned this pull request May 8, 2020
Open
47 tasks
@HaraldPanten
Copy link
Contributor Author

Hi @rousseldenis thanks for your review.

Done!

BTW... How could I solve failing tests? It seems to become from another module, right?

@HaraldPanten
Copy link
Contributor Author

Hi @rousseldenis thanks for your review.

Done!

BTW... How could I solve failing tests? It seems to become from another module, right?

It seems they're working today... Yesterday there was something strange with base_location_geonames_import

@rousseldenis
Copy link
Contributor

Hi @rousseldenis thanks for your review.
Done!
BTW... How could I solve failing tests? It seems to become from another module, right?

It seems they're working today... Yesterday there was something strange with base_location_geonames_import

yes, I restarted builds. You can follow conversation there : #906

@HaraldPanten
Copy link
Contributor Author

Hi @rousseldenis thanks for your review.
Done!
BTW... How could I solve failing tests? It seems to become from another module, right?

It seems they're working today... Yesterday there was something strange with base_location_geonames_import

yes, I restarted builds. You can follow conversation there : #906

Ok, I see...

Fortunately, it seems to be solved. 👍

skeller1
skeller1 suggested changes May 9, 2020
View reviewed changes
partner_contact_department/README.rst Show resolved Hide resolved
partner_contact_department/__manifest__.py Outdated Show resolved Hide resolved
partner_contact_department/__manifest__.py Outdated Show resolved Hide resolved
partner_contact_department/models/__init__.py Outdated Show resolved Hide resolved
partner_contact_department/readme/CONFIGURE.rst Show resolved Hide resolved
partner_contact_department/tests/__init__.py Outdated Show resolved Hide resolved
partner_contact_department/tests/test_recursion.py Outdated Show resolved Hide resolved
partner_contact_department/models/res_partner.py Outdated Show resolved Hide resolved
skeller1
skeller1 approved these changes May 9, 2020
View reviewed changes
Copy link
Contributor

@skeller1 skeller1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review: 👍 LGTM

Maybe we could split the model classes in 2 files

Thank you for contributing

partner_contact_department/models/res_partner.py Show resolved Hide resolved
@HaraldPanten
Copy link
Contributor Author

@ValentinVinagre

@HaraldPanten
Copy link
Contributor Author

Hi @rousseldenis could you have a look?

thanks!

rousseldenis
rousseldenis approved these changes May 14, 2020
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@HaraldPanten
Copy link
Contributor Author

HaraldPanten commented May 21, 2020 •
edited
Loading

I think this one is ready to merge, right? @rousseldenis

@HaraldPanten
Copy link
Contributor Author

Hi @rafaelbn could you merge this one as well? 😝

@rafaelbn
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-908-by-rafaelbn-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f8dffbb into OCA:13.0 Jul 17, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 142a967. Thanks a lot for contributing to OCA. ❤️

@HaraldPanten HaraldPanten deleted the 13.0-mig-partner_contact_department branch July 22, 2020 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skeller1 skeller1 skeller1 approved these changes

@ValentinVinagre ValentinVinagre ValentinVinagre approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.